What was the significance of the battle at Dunkeld? Did it end the Jacobite attempt of 1689? Many pro jacobite sources dont even mention the action.

It was significant in the fact that it ended the rebellion of 1689, the Jacobites did form again in 1690 in Scotland but were crushed at Cromdale.

After the death of Bonnie Dundee command fell to Colonel Cannon, a good soldier but not suited to commanding a highland army, the result was the defeat at Dunkeld.

Most pro-jacobite sources dont metion the battle beause they assosiate jacobitism with nationalism.

The early Jacobite period seems like an extention of the civil wars. Take the battle of Inverlochy in 1645 for example clans vs clans or the battle of Tibbermuir 1644 lowland covenaters against the royalist clans under Montrose, simliar to Killiecrankie, also Montrose was John Graham of Claverhouses' ancestor.

So they dislike it since it was scots vs scots? highlander vs lowlander?

Was the Argyll regiment at Killiecrankie or involved in the campaign at all?

Yes, they dislike any mention of a civil war

There were not at the battle, however they were raised in May 1689, two months before the campaign, and I believe they were stationed in the lowlands somewhere. A company of this regiment went on to commit the massacre of Glencoe in 1692.